[16.0][FIX] l10n_th_account_tax: create wht move only for journal item with a wht id #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kittiu, |
Pani-k-folk
force-pushed
the
16.0-fix-l10n_th_account_tax-wht_certs
branch
from
9fca2f9
to
6fe45ef
Compare
Pani-k-folk
changed the title
Saran440
requested changes
Nov 11, 2024
There was a problem hiding this comment.
please, provide step to error.
and I think we should fixed error with line https://github.com/OCA/l10n-thailand/pull/478/files#diff-8fdb10d323cb0a62e8c6a2ee4c53aef21d7c0641da8b451e3de3be80aa778b6fR548
for filter account withholding tax and wht is selected
wht_moves = move.line_ids.filtered(lambda l: l.account_id.wht_account and l.wht_tax_id)
Pani-k-folk
force-pushed
the
16.0-fix-l10n_th_account_tax-wht_certs
branch
2 times, most recently
from
9760d8d
to
4ec377e
Compare
Pani-k-folk
changed the title
Pani-k-folk
force-pushed
the
16.0-fix-l10n_th_account_tax-wht_certs
branch
from
4ec377e
to
07e0889
Compare
|
@Saran440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fix, if there was a journal item marked as WHT, odoo would generate a WHT move even if there was no WHT ID.
If there were two WHT journal items and one of them required creating WHT certificates, odoo would attempt to retrieve all WHT moves to create the certificates. This caused an error because a WHT ID could not be found
After the fix, odoo will create WHT moves only for journal items with a WHT ID. As a result, when generating WHT certificates, no errors will occur as previously.